nvim-telescope / telescope-fzf-native.nvim

FZF sorter for telescope written in c
1.36k stars 45 forks source link

make option under installation doesn't work for m1 without alteration #79

Open jakestrahm opened 2 years ago

jakestrahm commented 2 years ago

following use {'nvim-telescope/telescope-fzf-native.nvim', run = 'make' } didn't work on m1.

modifying it to use {'nvim-telescope/telescope-fzf-native.nvim', run = ' arch -arm64 make' } worked.

just wanted to share, maybe adding a small note in documentation for people running into the same situation.

pearofducks commented 2 years ago

make is working fine for me on an m1, at least in that it doesn't report any errors or problems on compiling. To my knowledge there's nothing wrong with the artifact it produces either. 🤷

rkoval commented 2 years ago

make is working fine for me on an m1, at least in that it doesn't report any errors or problems on compiling. To my knowledge there's nothing wrong with the artifact it produces either.

Same here, though one note I'll add that may be relevant: I had originally set up my M1's vim setup under Rosetta (work tooling compatibility reasons). However, recently, I have been able to drop Rosetta altogether. Once Rosetta was dropped, nvim would load with errors complaining that telescope-fzf-native.nvim hadn't been built for arm64e. I had to remove my build directory for telescope-fzf-native.nvim and then re-run make, but I didn't have to specify any arch flag for it to start working again after that

Not sure if this is relevant in OP's or others' situations, but felt worth sharing

Conni2461 commented 1 year ago

You could try if you had more luck with the cmake builder.

Also maybe we want to integrate this: https://github.com/nvim-telescope/telescope-fzf-native.nvim/issues/23#issuecomment-1176581213 the person who mentioned a fork said that adding -target arm64-apple-macos11 fixes things. I can not test this, because i do not have a m1 available, but maybe someone else wants to pick it up, should be just two ifs, first check for macos and second check for architecture.

PR welcome :)

marcoSven commented 1 year ago

A quick alternative solution that worked for me on M1 is using gmake installed via https://formulae.brew.sh/formula/make

{"nvim-telescope/telescope-fzf-native.nvim", build = "gmake"} - folke/lazy

raphaelchristin commented 11 months ago

gmake worked for me too! Interestingly, I have never had any issues with this before updating telescope earlier today.

rywng commented 7 months ago

Alternative solution, without gmake:

https://github.com/nvim-telescope/telescope-fzf-native.nvim/issues/119#issuecomment-1873653249

maybe we should add docs in the readme to help users on apple SoC