nvim-telescope / telescope-fzf-native.nvim

FZF sorter for telescope written in c
1.38k stars 45 forks source link

refactor: making types more consistant + more test + ... #8

Closed Conni2461 closed 3 years ago

Conni2461 commented 3 years ago

Fix #9

FYI this project is not abandoned (yet). I am not prime, i maintain projects for at least a week. :rofl: I also have another performance improvement idea. Need to verify. PR is still WIP. I need to convert more types

After this PR:

Conni2461 commented 3 years ago

Note, do i want to move the discard handling to c?! So all that i needs to happen in lua land is

if pattern_obj.discard then
  self._discard_state.filtered = {}
end
Conni2461 commented 3 years ago

This branch might be faster than main:

image

kkharji commented 3 years ago

Just test it out, no issues and feels a bit faster indeed :star_struck:. On master, when launching the picker it, fzf used to take few milliseconds to start up and for the sections to appear

Conni2461 commented 3 years ago

Lets get this to main. (what could go wrong :laughing:)

I am already working on utf8 support ;)