[BUG] `make` enters interactive cmd.exe on Windows with MSYS2

midrare commented 1 year ago

On Windows with MSYS2, running make hangs because cmd /c enters cmd.exe interactive mode. (Also the command cmd /c was supposed to run doesn't run.)

Animation

The offending line in Makefile is this: ifeq ($(OS),Windows_NT). It needs to match Windows while excluding MSYS2.

According to https://stackoverflow.com/a/52062069 we can do this by looking for instances of ; in PATH:

ifeq '$(findstring ;,$(PATH))' ';'
    # is normal windows
else
    # is linux or linux-like (e.g. MSYS2) environment
endif

Conni2461 commented 1 year ago

does https://github.com/nvim-telescope/telescope-fzf-native.nvim/pull/87 help?

midrare commented 1 year ago

@Conni2461 Yes, #87 fixes the bug.

nvim-telescope / telescope-fzf-native.nvim

[BUG] `make` enters interactive cmd.exe on Windows with MSYS2 #82