search

nvim-telescope / telescope-fzf-native.nvim

FZF sorter for telescope written in c
1.35k stars 46 forks source link

Detect MSYS #89

Closed lukebakken closed 1 year ago

lukebakken commented 1 year ago

Fixes #88

Conni2461 commented 1 year ago

Thanks :)

i am sorry that i merge so late, i wanted someone to confirm if this fixes #82 + #88 + #90 (see #90 for conversation).

I sadly cant do any testing of my own

lukebakken commented 1 year ago

I will open a PR to add a Windows CI pipeline, which should catch regressions like #88

Conni2461 commented 1 year ago

We actually had a windows pipeline which build the makefile but we replaced it with cmake because it seemed to work better on windows and is now the preferred way to build on windows (even though i hate cmake).

The problem with windows is that there are so many different environments to build the binary. Mingw, MSVC (normal terminal, powershell) and there definitly was an issue #82 that was adressed with #87.

So yeah i dont know how to fix that. Like the plugin was done after a week and i only had to refine a couple of time and add smaller features but the build system was rewitten 100 times and all we do is compile 1 c file :(

lukebakken commented 1 year ago

I have no idea why I didn't think there is a Windows CI pipeline currently, but there it is. I must have been looking at something old. cmake works great on my machine, so thanks for pointing that out.

IMHO it would be reasonable for you to say "if you're on Windows, use cmake" and leave it as the only supported option.