search

nvim-telescope / telescope-project.nvim

MIT License
583 stars 53 forks source link

hotfix: fix property access on already installed plugin with projects #115

Closed AntoscencoVladimir closed 2 years ago

AntoscencoVladimir commented 2 years ago

@claidler Hello, please check it as soon as possible. There is a bug when user already have plugin installed and projects and then upgrade plugin with sort feature

Without this fix user have to delete the plugin and reinstall it again (to clear projects in file). This fix can be deleted during some time though

Sorry for that issue didn't spotted it during dev

claidler commented 2 years ago

Ah thanks for catching it so quickly

AntoscencoVladimir commented 2 years ago

Ah thanks for catching it so quickly

@claidler It will be great if someone else can check/test it too

Thanks in advance and again sorry for the issue!

claidler commented 2 years ago

Yeah I just don't have time at the moment unfortunately. I don't want to let users down by ignoring MR'S but also don't have time to test and not currently using neovim so it's not even on my system. Id love a solution to this. I look over the code and make sure there's nothing glaringly breaking before merging and that's the best I can do. Also not able to deal with very big MR's as they are too risky.

AntoscencoVladimir commented 2 years ago

Yeah I just don't have time at the moment unfortunately. I don't want to let users down by ignoring MR'S but also don't have time to test and not currently using neovim so it's not even on my system. Id love a solution to this. I look over the code and make sure there's nothing glaringly breaking before merging and that's the best I can do. Also not able to deal with very big MR's as they are too risky.

@claidler Ok, clear and thanks. Let me know if I can help in some way please. I like this project but unfortunately I'm not advanced in writing plugins with lua so that need more experienced developer to review PR. Anyway next time I will be more careful.