nvim-telescope / telescope-ui-select.nvim

MIT License
774 stars 18 forks source link

Fix handling `codeaction` items #27

Closed spoof closed 9 months ago

spoof commented 9 months ago

In the https://github.com/neovim/neovim/commit/9281edb334a374e7753d4a6b7a05e31120e39772 'codeaction' items type has changed to

{action: lsp.Command|lsp.CodeAction, ctx: lsp.HandlerContext}[]

instead of just table of 2 elements:

{ client_id, action }

So, because of that, plugin crashes with 'attempt to index a nil value' on getting item[2].title.

Tested: 0.10-dev, 0.9.4

PS. Should we add something like vim.fn.has('nvim-X') to enable new behaviour?

NickyTope commented 9 months ago

I have to uninstall until this is resolved, hope you can get to a good solution soon

Conni2461 commented 9 months ago

yeah we need some kind of version check here, there is a good percentage of users who prefer a stable neovim over nightly builds

Conni2461 commented 9 months ago

everything else looks good :+1:

csaez commented 9 months ago

Thanks for fixing this one! :raised_hands:

Conni2461 commented 9 months ago

thanks for providing a fix :D