nvim-telescope / telescope-ui-select.nvim

MIT License
774 stars 18 forks source link

fix: bump codeaction version requirement #30

Closed weskeiser closed 8 months ago

weskeiser commented 9 months ago

Fixes issue where it throws error on version 10.0 as described in this issue: https://github.com/nvim-telescope/telescope-ui-select.nvim/issues/29

weskeiser commented 8 months ago

@Conni2461 Could you take a look at this when you find the time?

Conni2461 commented 8 months ago

I am looking into it right now. but tbh i dont get the problem. if you have an outdated neovim nightly build, then telescope doesnt support that. if you decide to run neovim nightly we require an up to date build.

Neovim (v0.9.0) or the latest neovim nightly commit is required for telescope.nvim to work.

from the current readme. i merged the original branch with this version check because it worked with the latest nightly build at that time.

Conni2461 commented 8 months ago

i just build current master resulting in this version

NVIM v0.10.0-dev-1641+g53cc835b5
Build type: RelWithDebInfo
LuaJIT 2.1.1700008891
Run "nvim -V1 -v" for more info

running lua print(vim.version.cmp(vim.version(), vim.version.parse "0.10.1-dev")) results in -1 running lua print(vim.version.cmp(vim.version(), vim.version.parse "0.10")) as well lua print(vim.version.cmp(vim.version(), vim.version.parse "0.10.0")) as well.

only lua print(vim.version.cmp(vim.version(), vim.version.parse "0.10.0-dev")) results in 0

running codeactions on this version works fine. It also works perfectly fine on nvim-0.9.4 (which is my daily driver version). Now checking out this branch breaks neovim nightly version i just compiled, 0.9.4 still works

image image

So i've have 0 idea which neovim version you guys are running, and i dont see how this fixes anything. i need more information whats actually wrong here.

Conni2461 commented 8 months ago

no idea what version 10.0 means, ngl

image image image this is the last nightly build which still shows a -dev version: https://github.com/neovim/neovim/releases/tag/nightly

weskeiser commented 8 months ago

Turns out it was an outdated build and I was unaware. Closing this, thanks @Conni2461.