First of all thanks a lot for the awesome plugin :) It's a small but very sweet UI improvement - I love things like this!
I believe this commit introduced a regression. If I choose something, on_choice is called twice. I don't have a minimal_init, but you can probably try it with your own init. To reproduce, run this little script:
What you will see is two notifications, {} and the actual choice. I believe it's because actions.close is called even in case I actually selected something. This introduces some hard-to-track issues in code that is using vim.ui.select.
Hello,
First of all thanks a lot for the awesome plugin :) It's a small but very sweet UI improvement - I love things like this!
I believe this commit introduced a regression. If I choose something,
on_choice
is called twice. I don't have a minimal_init, but you can probably try it with your own init. To reproduce, run this little script:And then select any item.
What you will see is two notifications,
{}
and the actual choice. I believe it's because actions.close is called even in case I actually selected something. This introduces some hard-to-track issues in code that is using vim.ui.select.