nvim-telescope / telescope.nvim

Find, Filter, Preview, Pick. All lua, all the time.
MIT License
14.98k stars 818 forks source link

Highlight groups not changing on fly on nvim v0.8 only #2202

Open siduck opened 1 year ago

siduck commented 1 year ago

Description

Hello, Telescope highlight groups no longer change on fly on neovim v0.8, however they do work on v0.7

https://user-images.githubusercontent.com/59060246/196692776-5eba00bc-3d05-41e5-91f5-aba7d54188dc.mp4

Neovim version

NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by void-buildslave@a-fsn-de

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

Operating system and version

Gnu / Void linux

Telescope version / branch / rev

master

checkhealth telescope

telescope: require("telescope.health").check()
========================================================================
## Checking for required plugins
  - OK: plenary installed.
  - OK: nvim-treesitter installed.

## Checking external dependencies
  - OK: rg: found ripgrep 13.0.0
  - OK: fd: found fd 8.4.0

## ===== Installed extensions =====

## Telescope Extension: `terms`
  - INFO: No healthcheck provided

## Telescope Extension: `themes`
  - INFO: No healthcheck provided

Steps to reproduce

  1. Open telescope

  2. Go into normal mode

  3. Run this command hi TelescopeResultsNormal guibg=#ffffff

Expected behavior

Changing highlight groups must work on fly.

Actual behavior

i have to reopen telescope to see the changes ( changed hl groups )

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvim/site]]
local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'
local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      {
        'nvim-telescope/telescope.nvim',
        requires = {
          'nvim-lua/plenary.nvim',
          { 'nvim-telescope/telescope-fzf-native.nvim', run = 'make' },
        },
      },
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
      display = { non_interactive = true },
    },
  }
end
_G.load_config = function()
  require('telescope').setup()
  require('telescope').load_extension('fzf')
  -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing Telescope and dependencies.")
  vim.fn.system { 'git', 'clone', '--depth=1', 'https://github.com/wbthomason/packer.nvim', install_path }
end
load_plugins()
require('packer').sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]
siduck commented 1 year ago

@fdschmidt93 any idea? :thinking:

Conni2461 commented 1 year ago

I'll look into it in the next couple of days. I'll probably bisect neovim and figure out what actually changed upstream between 0.7.2 -> 0.8.0. Maybe its an upstream bug because i can't think of anything we should do differently.

Please be patient i have a pretty busy week but i'll try to find the time in the evening to do this :)

siduck commented 1 year ago

No worries! Take your own time :D

Conni2461 commented 1 year ago

might be caused by https://github.com/neovim/neovim/pull/13457

I have not tested this, so i dont wanna point fingers to "bugs" or stuff, but it might be interesting to look into what actually changed in this PR and what we need to adept to fix this issue