nvim-telescope / telescope.nvim

Find, Filter, Preview, Pick. All lua, all the time.
MIT License
15.43k stars 824 forks source link

Using <Tab> key in git_status picker moves the selector to the bottom #3192

Open ZenithFlux opened 2 months ago

ZenithFlux commented 2 months ago

Description

Whenever <Tab> key is pressed to stage a file in git_status picker, the selector moves to the bottom of the window. This makes staging multiple files cumbersome as you have to move up each time you stage.

I created this same issue (#3002) for Telescope 0.1.6, but it was closed as it seemed to be fixed. However, the issue is reoccurring in the latest release.

Neovim version

NVIM v0.10.0
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068

Operating system and version

Linux Mint 21.3

Telescope version / branch / rev

telescope 0.1.8

checkhealth telescope

telescope: health#telescope#check

Checking for required plugins ~
- OK plenary installed.
- OK nvim-treesitter installed.

Checking external dependencies ~
- OK rg: found ripgrep 14.1.0 (rev e50df40a19)
- WARNING fd: not found. Install [sharkdp/fd](https://github.com/sharkdp/fd) for extended capabilities

===== Installed extensions ===== ~

Telescope Extension: `fzf` ~
- OK lib working as expected
- OK file_sorter correctly configured
- OK generic_sorter correctly configured

Steps to reproduce

  1. Open telescope.builtin.git_status() picker.
  2. Move up a few files in the picker.
  3. Press <Tab>.

Expected behavior

The selector should not move when staging or unstaging files in the git_status picker.

Actual behavior

Selector jumps to the bottom of the picker when <Tab> is pressed to stage the file.

Minimal config

local lazypath = vim.fn.stdpath 'data' .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system {
    'git',
    'clone',
    '--filter=blob:none',
    'https://github.com/folke/lazy.nvim.git',
    '--branch=stable',
    lazypath,
  }
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({{
    'nvim-telescope/telescope.nvim',
    branch = '0.1.x',
    }},
{})
jamestrew commented 1 month ago

Looks like it's this commit that should be backported: https://github.com/nvim-telescope/telescope.nvim/pull/2372

@Conni2461 should be safe to backport when you get a chance.