search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
2.02k stars 182 forks source link

New icon for Makefile #198

Closed lkabuci closed 1 year ago

alex-courtis commented 1 year ago

Do you have an icon in mind?

lkabuci commented 1 year ago

Do you have an icon in mind?

I think the gnu logo will be good.

alex-courtis commented 1 year ago

We actually do have an icon for makefile however that's not much use as it should be capitalised. https://github.com/nvim-tree/nvim-web-devicons/blob/master/lua/nvim-web-devicons.lua#L821

We need to capitalise that.

GNUmakefile also exists.

alex-courtis commented 1 year ago

A PR would be gratefully appreciated.

lkabuci commented 1 year ago

Should we overwrite the 'makefile' with 'Makefile' or append it so we can have both?

alex-courtis commented 1 year ago

GNU make wants "GNUmakefile, makefile, and Makefile, in that order."

Let's have them all.

alex-courtis commented 1 year ago

It looks like nerd font has a makefile icon: https://www.nerdfonts.com/cheat-sheet

We should use that one, to be consistent.