feat: darker icons for light colorschemes

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim

MIT License

2.02k stars 182 forks source link

feat: darker icons for light colorschemes #213

Closed mg979 closed 1 year ago

mg979 commented 1 year ago

fixes #193

mg979 commented 1 year ago

I'll add some tolerance in the color change, because actually only very light colors need to be darkened.

mg979 commented 1 year ago

I don't invert them anymore, they are just darkened, I think it's pretty decent this way.

alex-courtis commented 1 year ago

This works beautifully. The resulting script is well formatted too.

mg979 commented 1 year ago

I removed the old script, now there's only one, the whole thing can be run from the shell:

make colors

The icons should be a bit darker too, but not too much. The folder icon used by NvimTree seems to be their own, it's not in nvim-devicons, so it cannot be made darker with this script.

mg979 commented 1 year ago

With this setup there's only make colors to run.

CONTRIBUTING.md should mention that:

after adding new icons make colors should be run
lifepillar/colortemplate should be installed and in runtimepath (command would fail without it)

Can you create CONTRIBUTING.md? I don't have a template for that, nor I know exactly what would go in there.

alex-courtis commented 1 year ago

Can you create CONTRIBUTING.md? I don't have a template for that, nor I know exactly what would go in there.

Done. Please review.

I'll deal with code style later as it will create noise in this PR.

CI may be impossible. We can address that if it ever becomes a problem.

alex-courtis commented 1 year ago

Very happy with the outcome here!