search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.98k stars 183 forks source link

dummy change to test CI #234

Closed alex-courtis closed 1 year ago

alex-courtis commented 1 year ago

@gegoune CI is running, however there are a couple of issues:

  1. not run for PR branches, like this one
  2. (manual run) failed as it's missing dependencies: https://github.com/nvim-tree/nvim-web-devicons/actions/runs/4463802207
alex-courtis commented 1 year ago

I'm keen to get this into nvim-tree once we've got it all working here.

gegoune commented 1 year ago

https://github.com/nvim-tree/nvim-web-devicons/pull/235 should fix point 2. Point 1: this is scheduled run, it will run daily, not on branches/PRs unless manually triggered.

alex-courtis commented 1 year ago

235 should fix point 2. Point 1: this is scheduled run, it will run daily, not on branches/PRs unless manually triggered.

Fantastic! Tasks all running successfully with nice output: https://github.com/nvim-tree/nvim-web-devicons/actions/runs/4475379933/jobs/7864741163#step:11:231

Unfortunately create-pull-request is failing; what should that be doing? I'm happy enough with the checks :)

alex-courtis commented 1 year ago

Point 1: this is scheduled run, it will run daily, not on branches/PRs unless manually triggered.

Should we do this for PRs? It would be very useful for users that haven't updated / checked the generated colours.

gegoune commented 1 year ago

Yes, definitely.

gegoune commented 1 year ago

@alex-courtis #238 should do it, is that what you had in mind?

alex-courtis commented 1 year ago

Looking good so far: see #239 #240