nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.98k stars 183 forks source link

feat: add icon for `V` #247

Closed ttytm closed 1 year ago

ttytm commented 1 year ago

This PR adds an icon for the V language.

Just "v" was updated from currently linking to verilog, since it used by treesitter and lsp for the V language. "vlang" was added which is also used by those two, and many other V plugins.

alex-courtis commented 1 year ago

Unfortunately .v is the verlog file extension; this change would break verilog users.

neovim sets &ft to verilog for .v files.

verilog has been around for many years whilst the V programming language is very new, at 0.3.

Perhaps we could use .V for the V programming language.

ttytm commented 1 year ago

Thanks tackling this @alex-courtis!

Wasn't thinking straight that those are the actuall file extensions, not filetypes that are set by vim. Then vlang is not correct here either. Also, an upstream solution setting the &ft based on file contents wouldn't solve this.

For verilog we also have .verilog, .vlg, or .vh extensions working. V has just .v as required extension, so .V wouldn't work unfortunately afaik. Maybe this is an argument for the PR, else it looks like it's an actual real conflict and a user based override might be the only solution. Then please feel free to close the PR.

    override_by_extension = {
        ["v"] = {
            icon = "𝗩",
            color = "#5D87BF",
            cterm_color = "24",
            name = "V",
        },
    },
ttytm commented 1 year ago

Slipped out clicking close and then my internet went down. Maximum fail.

Updated the half finished comment @alex-courtis

alex-courtis commented 1 year ago

Maybe this is an argument for the PR, else it looks like it's an actual real conflict and a user based override might be the only solution.

Unfortunately it's all we can do.

The V language developers should have thought more carefully ;)