nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.98k stars 183 forks source link

fix(#75319): testing all the CI #248

Closed alex-courtis closed 1 year ago

alex-courtis commented 1 year ago

Love your work @gegoune - the PR name check works immediately after changing!

There might be an issue with the lighttheme hook - it's returning success even when a change was made to nvim-web-devicons-light.lua

Running checks locally works as intended:

:; pre-commit run --all-files
StyLua (Github)..........................................................Passed
Luacheck.................................................................Passed
Light Color Scheme Generator.............................................Failed
- hook id: lighttheme
- files were modified by this hook

Generating file with icons for light backgrounds...
Finished creating new file!
Generating cterm colors for dark background...
"lua/nvim-web-devicons.lua" "lua/nvim-web-devicons.lua" 2040L, 40156B written
Finished!"lua/nvim-web-devicons-light.lua" "lua/nvim-web-devicons-light.lua" 1554L, 27719BGenerating cterm colors for light background...
"lua/nvim-web-devicons-light.lua" "lua/nvim-web-devicons-light.lua" 1554L, 27638B written
Finished!

However... the CI run succeeded: https://github.com/nvim-tree/nvim-web-devicons/actions/runs/4592195810/jobs/8109010218

I think my expectations are incorrect or I am running things incorrectly locally.

gegoune commented 1 year ago

Seem like light colour requirements did not get caught in another PR. Will have a look at it as soon as I can.

alex-courtis commented 1 year ago

Seem like light colour requirements did not get fought in another PR. Will have a look at it as soon as I can.

Many thanks!

gegoune commented 1 year ago

@alex-courtis https://github.com/nvim-tree/nvim-web-devicons/pull/256 should fix it. https://github.com/nvim-tree/nvim-web-devicons/actions/runs/4665260901/jobs/8258416564?pr=256#step:10:24

gegoune commented 1 year ago

We can actually automate that more - create a commit from that diff on the pr if contributor didn't do that.