search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.98k stars 183 forks source link

fix: fixed icon of vue #266

Closed jfbeatit closed 1 year ago

jfbeatit commented 1 year ago

Fix reason: I use the font SauceCodePro Nerd Font Mono, after i update this plugin to the latest version, the vue icon can not display anymore.

gegoune commented 1 year ago

Try updading your font instead, this icon has been recently changed to more accurate one.

alex-courtis commented 1 year ago

Let's merge #264 first

gegoune commented 1 year ago

Not sure we want to merge this one, Alex. Vue icon has been very recently updated to one that's reverted here.

If we are using proper icons that are only available in recent font versions we will endlessly get requests like this while solution is to update fonts.

We will shortly provide compat tag for version 2 icons. That might solve the issue this pr tries to address.

Or we should come up with proper policy on how we handle those things.

alex-courtis commented 1 year ago

Not sure we want to merge this one, Alex. Vue icon has been very recently updated to one that's reverted here.

If we are using proper icons that are only available in recent font versions we will endlessly get requests like this while solution is to update fonts.

It looks like the vue icon on master is the correct v3 icon.

We will shortly provide compat tag for version 2 icons. That might solve the issue this pr tries to address.

Or we should come up with proper policy on how we handle those things.

The tag should be enough.

I have Hack Nerd Font Mono set as my browser font, so I can quickly see in the PR whether the icon is a valid (v3) icon.

alex-courtis commented 1 year ago

Or we should come up with proper policy on how we handle those things.

We could maintain a v2 branch rather than a tag, for reverting v3->v2 icons.

That's a lot of work and the branches will completely diverge.

alex-courtis commented 1 year ago

Optimistically closing: @jfbeatit can you please update your font to v3 and test again.

We'll reopen if that doesn't work.