search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.93k stars 183 forks source link

ci: remove colors from pre commit #349

Closed alex-courtis closed 7 months ago

alex-courtis commented 7 months ago

@gegoune I think I am getting this wrong.

The 'Pre-commit autoupdate' jobs have been passing, until I moved them to the makefile.

The jobs have been failing as make colors is called multiple times against all files. That has been reverted.

However it seems that the colors job has never been passing - it's not had vim-colortemplate in the runtimepath. It is marked as successful. This branch is at the last known good commit, with some rubbish in the job. It's passing: https://github.com/nvim-tree/nvim-web-devicons/actions/runs/7000075636

  1. Do we need colors in the pre-commit hook or is CI enough?
  2. How can we make them work, via make or other means?
gegoune commented 7 months ago

Before we dive into it - do you even use pre-commit? Maybe we should just remove it? I can look into making it work at some point soon if you would like to keep it.

alex-courtis commented 7 months ago

Before we dive into it - do you even use pre-commit? Maybe we should just remove it? I can look into making it work at some point soon if you would like to keep it.

I don't but I have several colleagues who make great use of it.

I'm quite happy to keep it - it's doing all the things that CI does and will make PRs easier.

gegoune commented 7 months ago

Let's keep it then.

We can

alex-courtis commented 7 months ago 
* see if it is required to run https://github.com/nvim-tree/nvim-web-devicons/blob/5efb8bd06841f91f97c90e16de85e96d57e9c862/.github/workflows/pre-commit-autoupdate.yml#L26
   in autoupdate workflow at all

That worked out well: https://github.com/nvim-tree/nvim-web-devicons/actions/runs/7066821461/job/19239344145

alex-courtis commented 7 months ago

pre-commit run --all-files seems OK now...