search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.93k stars 183 forks source link

feat: Add icons for executables. #351

Closed DreepyYunky closed 6 months ago

DreepyYunky commented 6 months ago

This adds icons for executable files.

This includes:

Non-related change: I changed the GDScript and Godot project files to it's NerdFont godot icon.

This is my first contribution, and I just started studying the code today, so please tell me if I did anything wrong.

gegoune commented 6 months ago

Thanks! Would you mind breaking non-exec related change into two separate PRs?

DreepyYunky commented 6 months ago

Thanks! Would you mind breaking non-exec related change into two separate PRs?

Ok, no problem. I'm going to revert the Godot-related changes.

alex-courtis commented 6 months ago

Looks like the light colours haven't been properly generated: https://github.com/nvim-tree/nvim-web-devicons/actions/runs/7220267899/job/19672971183?pr=351

Please run make or make colors to generate the cterm and light colours and commit the updates. See https://github.com/nvim-tree/nvim-web-devicons/blob/master/CONTRIBUTING.md#building

alex-courtis commented 6 months ago

I'm not actually seeing those icons with HackNerdFontMono-Regular.ttf

Which font are you using? Are you sure they are glyphs from nerd fonts?

20231219_143915

gegoune commented 6 months ago

Same for me on Iosevka.

DreepyYunky commented 6 months ago

I'm not actually seeing those icons with HackNerdFontMono-Regular.ttf

Which font are you using? Are you sure they are glyphs from nerd fonts?

20231219_143915

I use Gohu uni14 NerdFont.

Actually, By the image, the icon can be seen, It's the file with a binary inside.

DreepyYunky commented 6 months ago

So, anything else that's wrong?

gegoune commented 6 months ago

Thank you!

pysan3 commented 6 months ago

Hi, I get this error now. @DreepyYunky @gegoune @alex-courtis 

...re/nvim/lazy/nvim-web-devicons/lua/nvim-web-devicons.lua:253: Invalid highlight color: '#f28ba28'

What's up with the 7th digit?

gegoune commented 6 months ago

Followed up in https://github.com/nvim-tree/nvim-web-devicons/pull/357.

@alex-courtis Need to make sure ci picks those up in the future.

alex-courtis commented 6 months ago

Followed up in #357.

@alex-courtis Need to make sure ci picks those up in the future.

359