nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
2.05k stars 183 forks source link

feat: operating system icons #362

Closed miversen33 closed 9 months ago

miversen33 commented 9 months ago

361

There are a few things to call out here.

Pretty much all colors were established via "best guess"/"eyeball test". Others have figured out Apple/Windows color palettes and thus for these 2 I pulled the primary color from their established color palette. Feel free to adjust the color codes as needed. Color can be subjective after all :)

On colors, I did not do anything fancy for any of the OS icons for the "light" vs "default". It is a literal copy and paste between the 2. If someone wants different colors for the OS when requesting a "light" version of them, they can do that work lol.

I know that this PR doesn't exactly follow the Contributing guidelines request but given that is a bit chunky and adding stuff that doesn't really have a home, I figured it would be worth explaining that. Do let me know what you believe needs to be changed/fixed/etc to get this in :)

potential-icons.zip

alex-courtis commented 9 months ago

This looks great. The operating system distinction is not exposed to the user.

I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate.

@gegoune ? @Akmadan23 ?

miversen33 commented 9 months ago

This looks great. The operating system distinction is not exposed to the user.

I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate.

@gegoune ? @Akmadan23 ?

The initial commit had certain distros that had names like almalinux or rocky linux while others (such as redhat) did not. The removal of "linux" from the names was a way to make the names more consistent across the board. IMO they should either all have linux in their name, or none of them should in order to prevent confusion and make it easier on people using the icons in scripts/plugins

Akmadan23 commented 9 months ago

This looks great. The operating system distinction is not exposed to the user.

I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate.

@gegoune ? @Akmadan23 ?

Looks good. As @miversen33 said, either all or none should have linux in the name, and I'd go with none, since all of them are linux distros (except of course windows, macos and the BSDs, which are pretty obvious).

We should also update the color generation script to handle the icons_by_operating_system section now...

miversen33 commented 9 months ago

I attempted to add the icons_by_operating_system and while it "looked good", it seems to break the icons_by_file_type table in icons-light during the generation. Thus I am going to have to let someone else do that

Akmadan23 commented 9 months ago

It should be ok now. Could you please run it via make colors and push the updates?

miversen33 commented 9 months ago

Done :)

Akmadan23 commented 9 months ago

Awesome!