nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.93k stars 182 forks source link

New JS icon is not legible/recognizable in small size #373

Closed MunifTanjim closed 6 months ago

MunifTanjim commented 6 months ago

This is the new JS Icon:

image

image

In small size, it's not legible/recognizable at all:

image

The previous one was much better:

image

image

Same for CJS and MJS:

MunifTanjim commented 6 months ago

I think we should revert those 2 PRs.

cc: @alex-courtis @ronitkrshah

ronitkrshah commented 6 months ago

@MunifTanjim Well it's looking fine for me in Termux also in my PC

Screenshot_20240103-192939 Screenshot_20240103-192931_Termux

MunifTanjim commented 6 months ago

I guess it's terminal dependant.

MacOS

Alacritty:

image

Kitty:

image

WezTerm:

image
ronitkrshah commented 6 months ago

It depends on the font size of your terminal. Naturally, if you are using a smaller font size, it will show a small icon, and vice versa for a bigger font size.

MunifTanjim commented 6 months ago

Also depends on how the terminal renders the font.

In either way, the new icon is not very recognizable in small size. The previous one was immediately recognizable.

ronitkrshah commented 6 months ago

Hmm ....Then we should revert this 2 PRs

gegoune commented 6 months ago

I am leaning toward using 'official' icons as much as possible, mainly in order to avoid discussions which icon fits user's preferences best. @MunifTanjim obviously I am not having a go or disrespecting you and your concern here, it's just that this icon is what it is. Just my opinion.

MunifTanjim commented 6 months ago

Makes sense. No worries.

gegoune commented 6 months ago

Let's hear @alex-courtis' and @Akmadan23 opinions on this as well.

alex-courtis commented 6 months ago

Let's stick to the official icons.

If the official icon is not usable, it's something that should and very likely will be fixed in the font itself.

alex-courtis commented 6 months ago

Closing off; we can revisit and raise upstream if it continues to be a problem.