search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.93k stars 182 forks source link

revert: back to seti: js, cjs and mjs #377

Closed ofseed closed 3 months ago

ofseed commented 5 months ago

Do not merge both this and https://github.com/nvim-tree/nvim-web-devicons/pull/376

alex-courtis commented 5 months ago

Many thanks @ofseed and all for the great discussion.

I've updated https://github.com/nvim-tree/nvim-web-devicons/issues/192 to move to css class names. https://github.com/nvim-tree/nvim-web-devicons/issues/391 will then consolidate on seti icons https://github.com/nvim-tree/nvim-web-devicons/issues/392 will add a material set

I'll close this and https://github.com/nvim-tree/nvim-web-devicons/pull/377 - we will resolve all the js/ts icons in one change.

ofseed commented 3 months ago

Even though making icons more consistent is a work in progress, I still want to re-open this issue. After all, https://github.com/nvim-tree/nvim-web-devicons/commit/808627b8d412b2a6b6fc6eed816fec3557198b01 and https://github.com/nvim-tree/nvim-web-devicons/commit/33e27b859f549873a826d8aaa348fd31195e439f make no sense but a change.