search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.93k stars 182 forks source link

Regression: `NvimWebDeviconsHiTest` crashes #419

Closed simeonoff closed 3 months ago

simeonoff commented 3 months ago

I believe after merging this PR the panel now crashes with:

Screenshot 2024-03-18 at 08 36 45

I have the font-symbols-only-nerd-font cask installed via brew(macOS) which is at version 3.1.1 of the nerd font symbols and they don't include the prettier icon.

simeonoff commented 3 months ago

My bad, it was down to the way I have overwritten the config for some icons. 🫣

alex-courtis commented 3 months ago

This should be hardened / fixed. The failed icon can be shown as an error.

alex-courtis commented 3 months ago

Fix incoming: #423

@simeonoff I'd be most grateful if you could test this one with your original case:

cd /path/to/nvim-web-devicons
git pull
git checkout 419-hi-test-fail-on-bad-icon

When you're finished testing:

git checkout master
simeonoff commented 3 months ago

@simeonoff I'd be most grateful if you could test this one with your original case:

Will do!

simeonoff commented 3 months ago

Ok, tested it, works like a charm! No more errors being thrown.

Edit: Also nice to see a list of which icons have been overridden.