feat: add lck, m, mm, po, strings, x, xm, xcstrings icons

[olivertzeng]

add .zsh_plugins.txt add .zsh_history add init.lua add .m add .strings add .po add .x add .xm add .xcstrings

[alex-courtis]

Updating branch...

[olivertzeng]

Ok but isn’t objective c a long name And can I use Objective C++ instead of objectivecplusplus?

[olivertzeng]

Yeah sorry haven’t changed yet I will when I have time Sent from Proton Mail for iOS 於 週六, 3月 23, 2024 時間 14:08, gegoune @.***> 寫道： @gegoune requested changes on this pull request.

In lua/nvim-web-devicons/icons-default.lua: > + [".zsh_plugins.txt"] = {

• icon = "󱉋",
• color = "#ff0288",
• cterm_color = "198",
• name = "Antidote",
• },

⬇️ Suggested change

• [".zsh_plugins.txt"] = {
• icon = "󱉋",
• color = "#ff0288",
• cterm_color = "198",
• name = "Antidote",
• },

As per #422 (comment), this isn't stardard zsh file. Please remove.

In lua/nvim-web-devicons/icons-default.lua: > + [".zsh_history"] = {

• icon = "",
• color = "#6d8086",
• cterm_color = "66",
• name = "History",
• },

⬇️ Suggested change

• [".zsh_history"] = {
• icon = "",
• color = "#6d8086",
• cterm_color = "66",
• name = "History",
• },

This isn't standard either, but result of setting HISTFILE The file to save the history in when an interactive shell exits. If unset, the history is not saved.

Please remove.

In lua/nvim-web-devicons/icons-default.lua: > @@ -1958,6 +2000,18 @@ local icons_by_file_extension = { cterm_color = "255", name = "WebOpenFontFormat", },

• ["x"] = {
• icon = "",
• color = "#599eff",
• cterm_color = "111",
• name = "Tweak",
• },
• ["xm"] = {
• icon = "",
• color = "#519aba",
• cterm_color = "74",
• name = "Tweak",

It still say's Tweak.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

[alex-courtis]

Apologies @gegoune I did not see your earlier review comments as they were resolved.

@alex-courtis Perhaps what we need is an easy way to alias icons by users?

Yes. They can currently set however the override must provide everything - icon, colours etc. They could get, change name, set, however that's pretty ugly and can't be done at setup time.

421

[alex-courtis]

Merging as all @gegoune changes addressed.

[alex-courtis]

@olivertzeng this PR took a lot longer than it should have, taking up 3 people's time.

In future PRs for this project and others please:

1. Make small, atomic pull requests that address one issue.
2. Do not resolve review comments; leave it to the reviewers. I missed https://github.com/nvim-tree/nvim-web-devicons/pull/422#discussion_r1531557602 as it was marked resolved
3. Make the changes suggested or requested by the reviewers.

2 is absolutely mandatory for almost any open source project. 1 and 3 are a little flexible once you have proven yourself a trusted, repeated contributor.

[olivertzeng]

@olivertzeng this PR took a lot longer than it should have, taking up 3 people's time.

In future PRs for this project and others please:

1. Make small, atomic pull requests that address one issue.

2. Do not resolve review comments; leave it to the reviewers. I missed https://github.com/nvim-tree/nvim-web-devicons/pull/422#discussion_r1531557602 as it was marked resolved

3. Make the changes suggested or requested by the reviewers.

2 is absolutely mandatory for almost any open source project. 1 and 3 are a little flexible once you have proven yourself a trusted, repeated contributor.

Sorry for the inconvenience and thanks for the merge!

I'll follow these rules in the future!

[alex-courtis]

Many thanks for your contribution!