search

nvim-tree / nvim-web-devicons

lua `fork` of vim-web-devicons for neovim
MIT License
1.92k stars 181 forks source link

fix: remove dashes and underscores that seems to generate errors #441

Closed hasecilu closed 2 months ago

hasecilu commented 2 months ago

Fix #440

parkerkain-8451 commented 2 months ago

Thanks for the quick work on this @hasecilu - anecdotally the names mentioned in the diff are the same ones I'm seeing in my error messages!

gegoune commented 2 months ago

I don't have any problem with neither - nor _. I am on 0.10, so perhaps it's different on 0.9? Could someone on stable confirm if those work:

:hi foo-bar gui=bold
:hi foo_bar gui=bold

(Both work on 0.10.)

While / errors.

hasecilu commented 2 months ago

I don't have any problem with neither - nor _. I am on 0.10, so perhaps it's different on 0.9? Could someone on stable confirm if those work:

:hi foo-bar gui=bold
:hi foo_bar gui=bold

(Both work on 0.10.)

While / errors.

Same here but with NVIM v0.9.5, LuaJIT 2.1.1702233742. For me dash and underscore work and slash fails.

haakonfp commented 2 months ago

on v0.9.4. I have the issues mentioned in #440.

:hi foo-bar gui=bold errors. :hi foo_bar gui=bold does not error. :hi foo/bar gui=bold also errors.

meatballs commented 2 months ago

Turns out I was still on 0.9.1 Updating to 0.9.5 solved the problems in #440

gegoune commented 2 months ago

Thanks for the fix @hasecilu. Let's merge it in, group names look better that way anyway and it fixes backwards incompatibility.