search

nvim-treesitter / completion-treesitter

Treesitter source for completion-nvim and more
161 stars 5 forks source link

fix: api changes on completion-nvim side #10

Closed haorenW1025 closed 4 years ago

haorenW1025 commented 4 years ago

Just a small changes on completion-nvim side. I'm planning moving source.lua to subdirectory and use completion.lua as the main api, so before merging that to master I want to make sure your plugin doesn't just break because of it. Reference: https://github.com/haorenW1025/completion-nvim/pull/121

vigoux commented 4 years ago

Hi ! We have quite a bit change on our side too, can we merge that afterwards ?

haorenW1025 commented 4 years ago

Sure. Take your time:)

vigoux commented 4 years ago

It should be good now ! I think that this is just a rebase away from being merged ;-)

haorenW1025 commented 4 years ago

Hmm I'm quite confused now.. How should I do this? Should I fetch the master branch and rebase it into my branch? Sorry for being bad at git...

vigoux commented 4 years ago

Or I can do it if you want, maybe that's the easier !

haorenW1025 commented 4 years ago

Yeah I think it should be easier cause I just modified two lines. Closing this then, please notify me when you're finish! Thanks:)

vigoux commented 4 years ago

Should be good now !

haorenW1025 commented 4 years ago

@vigoux Thanks a lot! Sorry for the inconvenience!

vigoux commented 4 years ago

No worry, this is so tiny that is doesn't even bother ! And you are making so much good work !