Closed haorenW1025 closed 4 years ago
Hi ! We have quite a bit change on our side too, can we merge that afterwards ?
Sure. Take your time:)
It should be good now ! I think that this is just a rebase away from being merged ;-)
Hmm I'm quite confused now.. How should I do this? Should I fetch the master branch and rebase it into my branch? Sorry for being bad at git...
Or I can do it if you want, maybe that's the easier !
Yeah I think it should be easier cause I just modified two lines. Closing this then, please notify me when you're finish! Thanks:)
Should be good now !
@vigoux Thanks a lot! Sorry for the inconvenience!
No worry, this is so tiny that is doesn't even bother ! And you are making so much good work !
Just a small changes on completion-nvim side. I'm planning moving
source.lua
to subdirectory and usecompletion.lua
as the main api, so before merging that to master I want to make sure your plugin doesn't just break because of it. Reference: https://github.com/haorenW1025/completion-nvim/pull/121