Closed Olical closed 2 years ago
any updates for this?
The PR hasn't existed for very long at all, please give the maintainers much more time to respond. In the mean time I recommend using my fork if you need this update then switching back if it's eventually merged.
I'll let @steelsojka review this one as I am not really into fennel and sure about how this plugin works.
Sorry... been extremely busy. This looks good to me 👍
Nice! Thanks 😄 also if you update Aniseed and recompile your Lua will shrink dramatically. I rewrote and improved a LOT of the underlying module system a while back and I think before I opened this PR.
Not essential, but just a heads up!
Hi there! I noticed there were a couple of open issues around requiring Aniseed installed as a top level plugin for this plugin to work. That's not intended since Aniseed bundles itself in your Lua output, so you can use the exact version of Aniseed you compiled with at runtime. This PR addresses the following:
nvim-tree-docs.aniseed.core
instead ofaniseed.core
(which is missing unless you have Aniseed installed explicitly).autoload
overrequire
which is a new-ish feature that defers requiring of modules until they're accessed. This has simplified a little bit of the code that was trying to lazily load a module.def-
in a couple of places where a(local ...)
was used.(local ... (require ...))
calls into the(module ...)
form as well as convert to the lazy autoload.I've tried this out myself and it still generated documentation in a
.js
file for me, so I think everything's okay? This should fix #9 and #3 which are the same issue as well as potentially speed up loading of the plugin, or at least defer processing until it's invoked by the user.I hope this is useful, let me know if you have any questions or would like anything addressed!