Closed barrett-ruth closed 1 year ago
@xiaoshihou514 it looks like the clang tidy diagnostic test here failed. This is because you're trying to compare namespace fields of clang-tidy's diagnostic output:
with a guard namespace in the code here, instead of the actual diagnostic namespace.
Currently, the namespace has no relevant info to diagnostics and is thus not capture as part of the diagnostic in the clang-tidy linter code.
Solution:
Currently, the namespace has no relevant info to diagnostics and is thus not capture as part of the diagnostic in the clang-tidy linter code.
That's a neovim namespace used to "tag" stuff. clang-tidy
uses from_regex
which uses diag_fmt
so its namespace should be the Guard namespace. Dunno what happened, will investigate further.
The namespace may not be initialized before the test is run, so the field doesn't show up (nil).
@glepnir 's opinion is just to add an if to guard itself so we don't have to export this. Which does kind of make senseš¤
Tho I think separating formatter.lua and removing linter exports is as pleasant
The namespace may not be initialized before the test is run, so the field doesn't show up (nil).
Will change that after this batch of pr gets merged.
automate linter exports. slightly finnicky solution but should work... may be better functions or ways to accomplish the task.