search

nvimdev / guard-collection

collection the tools config for guard
MIT License
31 stars 9 forks source link

Fix rubocop #13

Closed kassio closed 1 year ago

xiaoshihou514 commented 1 year ago

Thanks for fixing this! Could you maybe write a test to verify it's parsing diagnostics correctly? There are insturctions for doing so in CONTRIBUTING.md

kassio commented 1 year ago

I tried to add tests, but this is a bit tricky as we'd need to install bundler, run bundle install before really executing bundle exec rubocop...

Is it possible to configure a linter/formatter partially? If so we could change the cmd/args to not use bundler by default. 🤷

xiaoshihou514 commented 1 year ago

I tried to add tests, but this is a bit tricky as we'd need to install bundler, run bundle install before really executing bundle exec rubocop...

You can just put the table in the config, change the cmd, test that it's ok, and put the string back. That should ensure the config at least works. (small changes between versions isn't that important)

Is it possible to configure a linter/formatter partially? If so we could change the cmd/args to not use bundler by default. 🤷

One could require the parse field from the repo I guess🤔, but it's up to you, if you think more people use rubocop not installed by bundler feel free to change that.

kassio commented 1 year ago

I decided to not use guard.nvim anymore. Thanks for the plugin, but it's not for me.