search

nvimdev / guard.nvim

async fast minimalist plugin make format easy in neovim
MIT License
448 stars 24 forks source link

Linter `fname` property is redundant #142

Closed UnderCooled closed 9 months ago

UnderCooled commented 9 months ago

https://github.com/nvimdev/guard.nvim/blob/d4782860b7da344d7409edbe7ee3693d5b8ea226/lua/guard/lint.lua#L42

Some linter is project based, why add filename to args?

xiaoshihou514 commented 9 months ago

Maybe, but fname stands for file name, so it does what it suggests. Also note guard gets diagnostics on a per buffer basis, so this parameter makes sense a lot of the times. Is there a particular linter you have a problem with?

UnderCooled commented 9 months ago

Yes, you are right, I forget it should be a per buffer basis.🤦‍♂️