search

nvimdev / lspsaga.nvim

improve neovim lsp experience
MIT License
3.47k stars 288 forks source link

# 1296 As the problem was not fixed, this report should not be closed. #1297

Open arafune opened 1 year ago

arafune commented 1 year ago 
          As the problem was not fixed, this report should not be closed.  While the origin may be in guard, (but not still 100% sure)  the bug appears during the code_action execution.  The bug should be closed after guard maintainer can fix the problem,

Originally posted by @arafune in https://github.com/nvimdev/lspsaga.nvim/issues/1296#issuecomment-1739132730

xiaoshihou514 commented 1 year ago

@arafune One thing I noticed with your setup is that the lsp format provided by pylsp seems to take forever, so much so that formatting doesn't seem to complete at all, maybe that's related?

edit: as a side note, I don't think pyright has formatting capabilities, and pylsp uses external formatters

arafune commented 1 year ago

While you say that the time required to format by lsp is relatively long, but I can't improve that myself, can I? Is it difficult to determine when a format ends in Guard?　　

xiaoshihou514 commented 1 year ago

Ok, my last comment wasn't exactly helpful, so here's a laid out thought:

Given the behaviour I observed, I imagine it may be a bug in guard.nvim that is solvable by us and could potentially solve your problem. I could not be sure because 1. pylsp formatting doesn't behave well on my machine, and 2. debugging the setup you provided is out of the scope of my interest and capabilities (it's best to reduce some of the noise and provide a reliable reproduction step or it's impossible to locate the problem)

I was suggesting revoming lsp formatting in your configuration because pylsp and pyright doesn't offer that, and also you noted that doing so solves your problem.

If you still want to help debug this problem, it would be of great help to provide what was stated above. If not then I am afraid this issue would hang around here going stale.

Thank you :)

glepnir commented 1 year ago

before issue closed because I guess it's guard issue :)