nvimdev / lspsaga.nvim

improve neovim lsp experience
MIT License
3.43k stars 285 forks source link

Using 'Finder" with custom width+height causes the peek window to view from center view instead of left view #1299

Closed idelice closed 11 months ago

idelice commented 11 months ago

Describe the bug

When using 'Finder', with the following custom layout config:

      finder = {
        max_height = 0.8, -- max_height of the finder window (float layout)
        left_width = 0.5, -- Width of the left finder window (float layout)

.. causes the peek window to center making it hard to read the actual code.

Screenshot 2023-09-30 at 01 15 17

Steps to reproduce

Nothing special other than changing the layout config as described in the previous section.

Expected behavior

I expect to the peek floating window to be left aligned or at least give me an option to set it left aligned. Or, making the 'Finder" smart enough to decide if it should be left-, right- or center aligned.

Neovim version (nvim -v)

latest

lspsaga commit

latest

Terminal name/version

iterm2

glepnir commented 11 months ago

causes the peek window to center making it hard to read the actual code.

sry I don't understand this and expect behavior..

idelice commented 11 months ago

causes the peek window to center making it hard to read the actual code.

sry I don't understand this and expect behavior..

Look at the right window which shows the code. You cannot see the left side of the code.

glepnir commented 11 months ago

maybe it's a bug looks like the left window cover right window

idelice commented 11 months ago

maybe it's a bug looks like the left window cover right window

Maybe :) you know your code better than I do

idelice commented 11 months ago

@glepnir your commit didn't fix the issue.

glepnir commented 11 months ago

hmm update to latest ? the right window should not be cover

idelice commented 11 months ago

hmm update to latest ? the right window should not be cover

I have the latest. It hasn't been fixed

glepnir commented 11 months ago

wired after this patch I can't reproduce it .

glepnir commented 11 months ago

how about now. (update)

idelice commented 11 months ago

Yes, not it works fine. Thank you!