search

nvimdev / lspsaga.nvim

improve neovim lsp experience
MIT License
3.41k stars 287 forks source link

fix: finder filter functions should work on items inside of result table rather than the result table as a whole #1404

Closed winter-again closed 5 months ago

winter-again commented 5 months ago

PR should fix #1394. Below is the example in the docs for filtering in the finder. Since it's specified that func should return a bool, I think the func is meant to be called on each element of the result table rather than the result table itself (which itself is just part of the map returned by vim.lsp.buf_request_all(); the reuse of names is confusing). This way, I think it's more like the user can write filters that act on the finder results. Correct me if I'm wrong.

Additionally, fn() in box.filter should also take client_id so that filters are applied properly.

If all looks good, I can clean up comments and/or change the name of result_member variable to something else.

require('lspsaga').setup({
  finder = {
    filter = {
      ['textDocument/references']  = function(client_id, result)
        -- your logic
        return true
      end
    }
  }
})