search

nvimdev / lspsaga.nvim

improve neovim lsp experience
MIT License
3.44k stars 286 forks source link

feat: add padding+hl to code_action servers #1420

Closed KevinSilvester closed 4 months ago

KevinSilvester commented 6 months ago

Before

image

After

image

Before

image

After

image
glepnir commented 5 months ago

seems like top border is hidden ?

KevinSilvester commented 5 months ago

I think that may be due to a separate issue with the preview window.

I haven't really looked into the cause of the issue. But from my experience the preview window sometimes appears underneath Code Actions window when:

Plus all the screenshots under 'Before' were using the current main branch of lspsaga without any changes to its code. This is a screen recording of the window overlap when using the main branch.

https://github.com/nvimdev/lspsaga.nvim/assets/56918431/cd591e4d-f504-4bec-8e3b-057bd6452420

glepnir commented 4 months ago

After new refactor so do we still this now ?

KevinSilvester commented 4 months ago

Yup all good to go. The refactor seems to have fixed the overlapping issue

image
glepnir commented 4 months ago

oh next step is refactor the ui of code action :) diagnostic jump more fancy now :p