nvimdev / lspsaga.nvim

improve neovim lsp experience
MIT License
3.37k stars 285 forks source link

Option show_code_action from diagnostic jump window not working #1455

Closed diegoulloao closed 1 month ago

diegoulloao commented 1 month ago

Describe the bug

It just doesn't work. I am missing something?

require('lspsaga').setup({
  diagnostic = {
    show_code_action = false -- doesn't work
  },
})

UPDATE

Fixed. The right option is auto_preview = false

require('lspsaga').setup({
  diagnostic = {
    auto_preview = false
  },
})

Screenshot 7

Steps to reproduce

Just jump by diagnostic to diagnostic

Expected behavior

-

Neovim version (nvim -v)

0.10.0

lspsaga commit

200256d

Terminal name/version

iterm2 3.5.0

diegoulloao commented 1 month ago

BTW how I can remove the corner label H:1?

glepnir commented 1 month ago

did you install diff ts parser. title can be improve if there is only one diagnostic.

diegoulloao commented 1 month ago

did you install diff ts parser. title can be improve if there is only one diagnostic.

Sorry I didn't get you. If is the treesitter error what are you referring to, that's resolved. Finally I was able to hide the action preview at the top of the jump diagnostic window by setting auto_preview = false, (I think the web doc isn't updated).

About the title H:1, I understand that's no option to disable it yet, right? I'd like to.

Thanks!

glepnir commented 1 month ago

currently no option to disable it. so it can be improve. about tresitter error it's hard to find out why i mean the error from neovim. for me i don't get this error in diff action preview window

image
diegoulloao commented 1 month ago

Now it looks like this:

Screenshot

Before remove the diff action preview window, I fixed the treesitter error, I was able to see the diff with highlighted colors all working good.

About the corner label/title, it would be good to provide an option to hide it, I'm using a very clean "ui" looking and for sure other users are doing it too, so in this case is better for us to just have the floating window with clean borders.

Thanks for replying.

glepnir commented 1 month ago

yup you can use ui.button to change the type of button arrow cube etc. and i has been update yesterday if only one diagnostic titile will not shown.

diegoulloao commented 1 month ago

Thanks! Marked as completed: ba6b071