search

nvimtools / hydra.nvim

Create custom submodes and menus
MIT License
145 stars 8 forks source link

Added ability to hide hydra hint on show #25

Closed miversen33 closed 9 months ago

miversen33 commented 9 months ago

Implementation of #24

I am not completely sure of this as a feature. I personally like it, but I don't know that it should be added to hydra. Unfortunately there doesn't seem to be a better way to handle this.

Thoughts/opinions?

benlubas commented 9 months ago

Why only the pink hydra?

miversen33 commented 9 months ago

I suppose I could add this to "non-pink" hydra's but in my head the idea was, pink is the only hydra that can be "backgrounded" (IE, you are allowed to press other keys after the hydra body). It didn't make much sense to me to allow hiding the other hydras but it isn't a huge deal if you feel we should

benlubas commented 9 months ago

Yeah I think we might as well.

My first thought is for the window Hydra you might not want it to block your view of windows but still be able to pull up the hint.

miversen33 commented 9 months ago

Sounds valid to me. I will get that added to the PR this morning

miversen33 commented 9 months ago

Added support for other hydras as well. Give it a try and lemme know

miversen33 commented 9 months ago

Don't merge this yet, I found a bug with toggling the hint multiple times

miversen33 commented 9 months ago

Ok I think its stable now

miversen33 commented 9 months ago

Fixed again lol. I almost want to say we need unit tests but I don't even know how we would approach setting those up for this project.

miversen33 commented 9 months ago

I'm dicking with my original idea today so I will finish that out and if I see no more issues popup, I will merge. I apologize for that, I should have more thoroughly tested this out before submitting the PR

miversen33 commented 9 months ago

All seems well. Merging and closing