search

nvisconti / dropbox

0 stars 0 forks source link

dropbox Nate Visconti [iOS Designer Bootcamp] #2

Open nvisconti opened 8 years ago

nvisconti commented 8 years ago

Finished my assignment! Would love to know if there is a way to upload and link gifs to the readme. Had a hard time hosting it.

/cc @codepath

drnick23 commented 8 years ago

It looks like you're having some issues uploading the full code -- I am only seeing an incomplete version of it.

Be sure that if you commit, you are also pushing your latest changes. Please try uploading your full repo again! If you're having troubles, email me directly.

nvisconti commented 8 years ago

Hey Nick!

I thought I had it. I just tried to update again and now the Readme looks crazy. Is there any way that you can walk me through this on Thursday? Or over hangout? I watched Tim's video, but github is different now, and it looks like it has uploaded. Would love some help on looking at what I am doing wrong.

Cheers,

Nate

On Tue, Sep 22, 2015 at 5:01 PM, drnick23 notifications@github.com wrote:

It looks like you're having some issues uploading the full code -- I am only seeing an incomplete version of it.

Be sure that if you commit, you are also pushing your latest changes. Please try uploading your full repo again! If you're having troubles, email me directly.

— Reply to this email directly or view it on GitHub https://github.com/nvisconti/dropbox/issues/2#issuecomment-142456936.

nathan.visconti@gmail.com 650-483-5416 https://www.linkedin.com/in/natevisconti http://www.linkedin.com/pub/nathan-visconti/4/34/603/

drnick23 commented 8 years ago

The code runs for me, we can look at how you are submitting on Thursday.

Congrats on getting all the required tasks in, here are a few pointers on getting a bit more polish:

Also it was great seeing you participate early and often in the group support -- this next week there will be a lot of optional's, and the required's will be a step up in terms of getting comfortable with code, so I'm looking forward to seeing what you can do there!

nvisconti commented 8 years ago

Thanks!

I thought that a push with the TOS might be better, so that I retain the memory of the previous screen and I could dismiss it. Wrong in thinking that?

Thanks again.

On Tue, Sep 22, 2015 at 7:15 PM, drnick23 notifications@github.com wrote:

The code runs for me, we can look at how you are submitting on Thursday.

Congrats on getting all the required tasks in, here are a few pointers on getting a bit more polish:

  • some of your transitions are pushing instead of using modal's, for instance, the "view terms" is better served as a modal, although this could just be a matter of preference for you to use a push instead.
  • be consistent in your naming. Clear naming patterns will avoid potential confusion. For instance, your "photoViewController" should be named "PhotoViewController" -- just try to follow conventions when you see them. It's pendantic, but it will be like fingernails on chalkboard to an engineer to see that!

Also it was great seeing you participate early and often in the group support -- this next week there will be a lot of optional's, and the required's will be a step up in terms of getting comfortable with code, so I'm looking forward to seeing what you can do there!

— Reply to this email directly or view it on GitHub https://github.com/nvisconti/dropbox/issues/2#issuecomment-142472708.

nathan.visconti@gmail.com 650-483-5416 https://www.linkedin.com/in/natevisconti http://www.linkedin.com/pub/nathan-visconti/4/34/603/

drnick23 commented 8 years ago

It's true that a push saves a history of the stack in the navigation controller. However, a modal is like having a history of 1. When you dismiss the modal, it just throws itself away to reveal what it replaced earlier.

On Tue, Sep 22, 2015 at 7:29 PM, nvisconti notifications@github.com wrote:

Thanks!

I thought that a push with the TOS might be better, so that I retain the memory of the previous screen and I could dismiss it. Wrong in thinking that?

Thanks again.

On Tue, Sep 22, 2015 at 7:15 PM, drnick23 notifications@github.com wrote:

The code runs for me, we can look at how you are submitting on Thursday.

Congrats on getting all the required tasks in, here are a few pointers on getting a bit more polish:

  • some of your transitions are pushing instead of using modal's, for instance, the "view terms" is better served as a modal, although this could just be a matter of preference for you to use a push instead.
  • be consistent in your naming. Clear naming patterns will avoid potential confusion. For instance, your "photoViewController" should be named "PhotoViewController" -- just try to follow conventions when you see them. It's pendantic, but it will be like fingernails on chalkboard to an engineer to see that!

Also it was great seeing you participate early and often in the group support -- this next week there will be a lot of optional's, and the required's will be a step up in terms of getting comfortable with code, so I'm looking forward to seeing what you can do there!

— Reply to this email directly or view it on GitHub https://github.com/nvisconti/dropbox/issues/2#issuecomment-142472708.

nathan.visconti@gmail.com 650-483-5416 https://www.linkedin.com/in/natevisconti http://www.linkedin.com/pub/nathan-visconti/4/34/603/

— Reply to this email directly or view it on GitHub https://github.com/nvisconti/dropbox/issues/2#issuecomment-142473745.

nvisconti commented 8 years ago

Good to know! Thanks!

On Tue, Sep 22, 2015 at 8:44 PM, drnick23 notifications@github.com wrote:

It's true that a push saves a history of the stack in the navigation controller. However, a modal is like having a history of 1. When you dismiss the modal, it just throws itself away to reveal what it replaced earlier.

On Tue, Sep 22, 2015 at 7:29 PM, nvisconti notifications@github.com wrote:

Thanks!

I thought that a push with the TOS might be better, so that I retain the memory of the previous screen and I could dismiss it. Wrong in thinking that?

Thanks again.

On Tue, Sep 22, 2015 at 7:15 PM, drnick23 notifications@github.com wrote:

The code runs for me, we can look at how you are submitting on Thursday.

Congrats on getting all the required tasks in, here are a few pointers on getting a bit more polish:

  • some of your transitions are pushing instead of using modal's, for instance, the "view terms" is better served as a modal, although this could just be a matter of preference for you to use a push instead.
  • be consistent in your naming. Clear naming patterns will avoid potential confusion. For instance, your "photoViewController" should be named "PhotoViewController" -- just try to follow conventions when you see them. It's pendantic, but it will be like fingernails on chalkboard to an engineer to see that!

Also it was great seeing you participate early and often in the group support -- this next week there will be a lot of optional's, and the required's will be a step up in terms of getting comfortable with code, so I'm looking forward to seeing what you can do there!

— Reply to this email directly or view it on GitHub <https://github.com/nvisconti/dropbox/issues/2#issuecomment-142472708 .

nathan.visconti@gmail.com 650-483-5416 https://www.linkedin.com/in/natevisconti http://www.linkedin.com/pub/nathan-visconti/4/34/603/

— Reply to this email directly or view it on GitHub https://github.com/nvisconti/dropbox/issues/2#issuecomment-142473745.

— Reply to this email directly or view it on GitHub https://github.com/nvisconti/dropbox/issues/2#issuecomment-142482106.

nathan.visconti@gmail.com 650-483-5416 https://www.linkedin.com/in/natevisconti http://www.linkedin.com/pub/nathan-visconti/4/34/603/