search

nvisionative / nvQuickComponents

nvQuickComponents is a collection of versatile web components, based 100% on web standards, to help developers break free from framework churn.
GNU General Public License v3.0
12 stars 5 forks source link

Needs CI Builds for Pull Requests #4

Open SkyeHoefling opened 5 years ago

SkyeHoefling commented 5 years ago

There is no CI build for pull requests, we should add something. I have setup VSTS builds with stenciljs if we want to go that route and I can share or we can use a script with AppVeyor. Either way we should set up something for CI.

I can help set this up

david-poindexter commented 5 years ago

Excellent @ahoefling - looking forward to this! I can see pros/cons to both approaches. Which way are you leaning and how hard is it to switch later on should the need arise?

david-poindexter commented 5 years ago

@ahoefling should we seriously consider GitLab? I am thinking it has some advantages over AppVeyor. For what it is worth, this is what Ionic uses.

SkyeHoefling commented 5 years ago

Microsoft announced Azure DevOps (VSTS) is now supporting open source projects for free. I think if we want to go down the Azure DevOps path we could easily get this setup.

@nvisionative thoughts?

david-poindexter commented 5 years ago

@ahoefling we already have an nvisionative Visual Studio Online (VSTS) account, but using that would require collaborators to added to the project. Correct?

SkyeHoefling commented 5 years ago

I'll take a look at Azure DevOps for open source and see what real benefit it provides to us. The thing that jumps out at me is the 10 free pipelines. That basically means we can run 10 builds at once. Granted this project is in it's infancy and we don't expect it to have a demand to run that many builds but I can see our build env including 3 CI checks (windows, mac and linux) which would require 3 pipelines for 1 PR.

I'll investigate and report back what we need to do. We can make the decision if we want to go down the open source azure devops or use the nvisionative account

david-poindexter commented 5 years ago

@ahoefling sounds good. GitLab still looks like a viable option as well to me.

valadas commented 4 years ago

I have in Azure devops a build pipeline for Stencil and a Release Pipeline (manually trigered) to build and publish to NPM, ping me up if you want to dig in there...

david-poindexter commented 4 years ago

@valadas let's chat about this when I get back from vacation.