Closed SkyeHoefling closed 3 years ago
@ahoefling thanks for letting us know. I have been running Node 12.16.2 for a while now with no issues. I guess we'll have to keep an eye on this one and make sure the documentation reflects the recommended version at that point in time.
Could be a problem with linux since this was Node v12 on a GitHub Actions runner specified as ubuntu-latest
. Using the exact same runner v11 of node worked.
@ahoefling interesting - perhaps. Let us know if you think this is still a valid issue or not.
I found this bug while configuring a GitHub actions. I can try reproducing it as a PR, would that be helpful?
Describe the bug
nvQuickTheme will not work with NodeJS v12 as the
node-sass
dependency uses native c++ and there is a breaking change with a missing APIs between v11 and v12.To Reproduce
Steps to reproduce the behavior:
yarn install
commandExpected behavior
The dependencies should install correctly without errors
Screenshots
N/A - See Errors below
Errors
There was a method
IsNearDeath()
that was removed between v11 and v12 thatnode-sass
uses. After looking through thenode-sass
GitHub project it was recommended to update to v4.12 which is compatible with node v12+. There is a great support table on the npm package location for node-sass.nvQuickTheme doesn't take a direct dependency on
node-sass
but usesgulp-sass
which uses v4.8.3 ofnode-sass
on the latest code.Error Log from Build
Additional context
My workaround was downgrading to NodeJS v11 which seemed to fix the problem. According to the docs it isn't completly supported so there may be additional problems I'll run into with v11.