Closed jeremy-farrance closed 3 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells
Thank you @jeremy-farrance - I have some other things queued up for the next release and I'll review this when I work on the others. 🎉
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Added the conditional wrapper on each occurrence of target=, this way, for the majority of links that are local and do not open in a new window, you don't end up with menus full of empty target attributes. (e.g.
target=""
).Warning: I did test this. It also looks right. But your mileage may vary. :)
Related to Issue 243
Fixes #243
Description
added [?TARGET] - [/?] wrappers where needed
How Has This Been Tested?
Configured a DNN site's menus using the token template before and after the change, results were as expect (after) no empty target attributes.
Screenshots (if appropriate):
[x] Bug fix (non-breaking change which fixes an issue) [?] New feature (non-breaking change which adds functionality)
Checklist: