nvisionative / nvQuickTheme

nvQuickTheme is more than just a great minimalist DNN (DotNetNuke) theme. It is a powerful theme building framework and developer workflow.
https://nvisionative.github.io/nvQuickTheme/
Other
41 stars 40 forks source link

Update MainMenu.txt for slight better "target" #244

Closed jeremy-farrance closed 3 years ago

jeremy-farrance commented 4 years ago

Added the conditional wrapper on each occurrence of target=, this way, for the majority of links that are local and do not open in a new window, you don't end up with menus full of empty target attributes. (e.g. target="").

Warning: I did test this. It also looks right. But your mileage may vary. :)

Related to Issue 243

Fixes #243

Description

added [?TARGET] - [/?] wrappers where needed

How Has This Been Tested?

Configured a DNN site's menus using the token template before and after the change, results were as expect (after) no empty target attributes.

Screenshots (if appropriate):

image

[x] Bug fix (non-breaking change which fixes an issue) [?] New feature (non-breaking change which adds functionality)

Checklist:

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

david-poindexter commented 4 years ago

Thank you @jeremy-farrance - I have some other things queued up for the next release and I'll review this when I work on the others. 🎉

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication