nvisionative / nvQuickTheme

nvQuickTheme is more than just a great minimalist DNN (DotNetNuke) theme. It is a powerful theme building framework and developer workflow.
https://nvisionative.github.io/nvQuickTheme/
Other
41 stars 40 forks source link

Update division signs #304

Closed tksheppard closed 2 years ago

tksheppard commented 2 years ago

Related to Issue

Fixes #299

Description

This adds the scss math function which changes the use of division signs to instead use math.div. This will get rid of deprecation warnings.

How Has This Been Tested?

Changed and compiled.

Screenshots (if appropriate):

Types of changes

Checklist:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tksheppard commented 2 years ago

Wasn't aware calc() allowed for that. Was going off the recommendation made in the console, which I stopped reading after math.div. I like calc() much more, and removes the usage of scss:math. So, I changed over to use calc().