Update font awesome to latest version and usage

nvisionative / nvQuickTheme

nvQuickTheme is more than just a great minimalist DNN (DotNetNuke) theme. It is a powerful theme building framework and developer workflow.

https://nvisionative.github.io/nvQuickTheme/

Other

41 stars 40 forks source link

Update font awesome to latest version and usage #358

Closed tksheppard closed 9 months ago

tksheppard commented 9 months ago

Related to Issue

Fixes #357

Description

Updated the fontawesome free version to most recent (6.5.1)
Changed the font usage to only include the free Webfonts and CSS within the gulpfile
Updated includes to use correct CSS and Webfonts

How Has This Been Tested?

Made updates, ran gulp. Compiled and checked on local environment to make sure no errors.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

sonarcloud[bot] commented 9 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tksheppard commented 9 months ago

@david-poindexter I know we discussed multiple PR's, but I noticed issue #358 already outlined the necessary changes to font usage and include updates.

It's still tossing the warnings that @dnndiva was speaking about earlier, but I'm not sure what to do about these. This seems like a new warning. I even tried making sure the page is using fontawesome and it still gives these warnings.

david-poindexter commented 9 months ago

@david-poindexter I know we discussed multiple PR's, but I noticed issue #358 already outlined the necessary changes to font usage and include updates.

It's still tossing the warnings that @dnndiva was speaking about earlier, but I'm not sure what to do about these. This seems like a new warning. I even tried making sure the page is using fontawesome and it still gives these warnings.

@tksheppard it is totally fine for this to all be in one PR - thank you!

As it relates to the warning, this is for a woff file. At this point, I see no reason why need to continue including woff files. woff2 is supported now on all modern browsers. I will approve this PR and I'll create a separate issue for the drop of woff support in nvQuickTheme.