search

nvk / walletsrecovery.org

Information about wallet defaults for external recovery
https://walletsrecovery.org/
115 stars 96 forks source link

Add blockchain.com #40

Closed Sjors closed 4 years ago

Sjors commented 4 years ago

Basic BIP39 & BIP44, with multiple accounts (default n=0). Added links to relevant support pages.

The derivation code is here: https://github.com/blockchain/blockchain-wallet-v4-frontend/blob/v4.21.7/packages/blockchain-wallet-v4/src/types/HDWallet.js#L79-L84

nvk commented 4 years ago

Due to the amount of issues this wallet has had. Will only be listed with a warning.

Sjors commented 4 years ago

There's already a general disclaimer on the site.

nvk commented 4 years ago

Not enough for a wallet this bad.

Sjors commented 4 years ago

@nvk I don't have time for political BS

nvk commented 4 years ago

I've clarified the spec. I will add BCI with the appropriate warning.

Wallets which have been frequently exploited, or which have endangered users by misrepresenting forked coins as if they are Bitcoin, may only be included with a warning.

Sjors commented 4 years ago

I would just stick to providing factual information, i.e. derivation paths and recovery options (which can be used to migrate to other wallets). Otherwise you're just getting drama, and the people with expertise are going to think twice before updating your info (e.g. yours truly doesn't get paid to recover knowledge from 2+ years ago).

There's already a generic information page about wallets on bitcoin.org, with all the politics that comes with that. They delisted Blockchain back in 2014, officially for reasons that have since been fixed: https://github.com/bitcoin-dot-org/bitcoin.org/pull/663

Reminding people of SegWit2x makes sense. There's a few more wallets that did that: https://medium.com/@DCGco/bitcoin-scaling-agreement-at-consensus-2017-133521fe9a77 Some wallets weren't around back then, so we don't know how they would have behaved.

There were also wallets that were about to switch their users to UASF without informing them.

I'm not aware of any exploit, so far, of the blockchain wallet, ever since the extremely scary RNG bug in 2014. It's been rewritten from scratch twice since. Several other wallets on the page have had zero-days far more recently, some seriously exploited. Some of those were screwups, by companies with way more resources than Blockchain had back then.

nvk commented 4 years ago

I understand. Do you still support other forks of bitcoin? Which other wallets have recent zero days? I’d like to document that too.