nvkelso / natural-earth-vector

A global, public domain map dataset available at three scales and featuring tightly integrated vector and raster data.
https://www.naturalearthdata.com/
Other
1.79k stars 370 forks source link

min_zoom revisions and other final cleanups #223

Closed nvkelso closed 7 years ago

nvkelso commented 7 years ago

In performing QA for https://github.com/nvkelso/natural-earth-vector/issues/202 a few issues have come up...

nvkelso commented 7 years ago

For population_rank (or pop_rank because SHP 10 char column name limits):

if population >= 1000000000: 
    population_rank = 18
elif population >= 100000000: 
    population_rank = 17
elif population >= 50000000: 
    population_rank = 16
elif population >= 20000000: 
    population_rank = 15
elif population >= 10000000: 
    population_rank = 14
elif population>= 5000000:
    population_rank = 13
elif population>= 1000000:
    population_rank = 12
elif population >= 500000:
    population_rank = 11
elif population >= 200000:
    population_rank = 10
elif population >= 100000:
    population_rank = 9
elif population >= 50000:
    population_rank = 8
elif population >= 20000:
    population_rank = 7
elif population >= 10000:
    population_rank = 6
elif population >= 5000:
    population_rank = 5
elif population >= 2000:
    population_rank = 4
elif population >= 1000:
    population_rank = 3
elif population >= 200:
    population_rank = 2
elif population > 0:
    population_rank = 1
nvkelso commented 7 years ago

physical areas need to know if they dup an admin name (like Cuba)

This should be resolved by collision rank instead in the style.

UPDATE: This still fails Greenland, but mostly works looking at basic QGIS config.

nvkelso commented 7 years ago

so disputed areas, take from their boundary line min_zoom – else Kashmir is a mire

Is mostly working but Kashmire needs a little more work

nvkelso commented 7 years ago

10m, 50m, 110m coastline min_zoom needs to match land scale rank min_zoom

I think this is the last big thing left besides zipping everything up and posting v4 of Natural Earth to the public site?

nvkelso commented 7 years ago

Coastlines were 99.9% good, couple dozen edits in https://github.com/nvkelso/natural-earth-vector/commit/63b9b086899311673b408ffbf846a45b88e735bb.

nvkelso commented 7 years ago

Let's call this done :)