search

nvkelso / natural-earth-vector

A global, public domain map dataset available at three scales and featuring tightly integrated vector and raster data.
https://www.naturalearthdata.com/
Other
1.76k stars 368 forks source link

Provinces : Cambodia missing a province. #424

Open hugolpz opened 3 years ago

hugolpz commented 3 years ago

File

Error

Kampong Cham (South-Eastmost) currently includes Tboung_Khmum_Province but should not. These are 2 distinct provinces.

Visual

(Erroneous) Map below based on NE 4.1. 20140301000734!Cambodia_Kampong_Cham_locator_map svg (1)

GADM vs NE

Screenshot_2020-10-14_00-02-25

elliotap commented 3 years ago

Verified: see https://www.stat.go.jp/english/info/meetings/cambodia/e11f_dc2.html for Cambodian Economic Census w/ maps.

Screen Shot 2021-03-16 at 1 15 45 PM

Compare to OSM:

Screen Shot 2021-03-16 at 11 53 04 AM

Propose creating new admin-1 for Tboung Khmum (est. 2014) and adding new feature at 11.91600502098655, 105.65107594825297 to 10m populated places for its capital, Suong (https://en.wikipedia.org/wiki/Suong)

Admin-1 boundary between provinces to be aligned with centerline for Mekong from 10m_rivers_lakes_centerlines

Screen Shot 2021-03-16 at 11 55 14 AM
nvkelso commented 3 years ago

I agree with this change.

Please also propose the Wikidata IDs here for the new province Tboung Khmum and confirm the remaining province part's wikidata ID for Kampong Cham. You'll also need to update properties like ISO admin-1 codes.

Thanks for calling out the river boundary and the needed admin-1 capital, that's helpful to QA :)

NOTE: The map image in the issue description highlights a unrelated province in red.

hugolpz commented 3 years ago
Hi there, I went in to pick the Wikidata Qids for adm1. Wikidata Qid English Wikipedia name Maps
Q15623578 Tboung_Khmum_Province Cambodia_Tbong_Khmum_locator_map svg
Q142258 Kampong_Cham_Province Cambodia_Kampong_Cham_locator_map svg

Please note that Q15623578 has 5 identifiers (ISO 3166-2,Freebase ID,GeoNames ID,OSM relation ID,Who's on First ID), while Q142258 has 9 (ISO 3166-2,FIPS 10-4 (countries and regions),Freebase ID,GeoNames ID,KBpedia ID, OmegaWiki Defined Meaning, OSM relation ID, US National Archives Identifier, Who's on First ID).

nvkelso commented 3 years ago

Process detailed in https://github.com/nvkelso/natural-earth-vector/issues/396#issuecomment-789428141.

hugolpz commented 2 years ago

@Elliotap hello, 1) Did you see the wikidata info above and 2) are you able to lead this integration ? I may try to follow issue 396 cited above. I didn't touch Qgis since 2014 and I have no idea if my attempt will be of suitable quality for integration.

elliotap commented 2 years ago

Hi @hugolpz, hope you are well. I haven’t been as active on this project lately as I would have liked to have been. I do have a bit of time this weekend where I can make a branch that includes this change, if you only need a file with the provinces updated for a hotfix or what have you. I am an occasional volunteer, so if your purposes require the change to be integrated into a natural earth release, the turnaround will be longer

hugolpz commented 2 years ago

Hello @elliotap, thanks for the proposal. Yes, it would help. I'am assisiting a Cambodia geography PhD candidate to create few maps for her thesis. Those maps will also end up uploaded to Wikimedia Commons, the image repository of Wikipedia and on Wikipedia. I'm currently slowed down because of this missing province in my GIS sources, indeed. If you have some free time to provide a branch with that fix I will take it indeed : )

Koen-vdl commented 1 month ago

This remains an issue in 2024. Would be great to see Kampong Cham Province and Tboung Khmum Province corrected. If it helps: Tboung Khmum province was established by Royal Decree no. NS/RKT/1214/1445 dated 31 December 2013.

nvkelso commented 1 month ago

Please take a look at the v6 beta of Natural Earth at https://shadedrelief.com/ne-draft/ to confirm if these new provinces are added.