nvlad / yii2support

Yii2 Support for PhpStorm / IntelliJ IDEA
https://plugins.jetbrains.com/idea/plugin/9388-yii2-support
Other
295 stars 54 forks source link

Url autocomplete #243

Closed siggi-k closed 4 years ago

siggi-k commented 4 years ago

What steps will reproduce the problem?

TransactionActualController

public function actionCreateTransactionActual () {...}

View

now create Url::to([create-transaction-actual]) you type :

Url::to([create..

What is the expected result?

Url::to([create-transaction-actual])

What do you get instead?

Url::to([create-trans-actual])

Because there is a simple replacement of "action", regardless of whether it is at the beginning of the name or in the middle or at the end

Additional info

Q A
IDE Name PhpStorm
IDE Version
Plugin version
Yii App Template basic / advanced
nvlad commented 4 years ago

Hi! Released plugin version 0.10.57.33. Try for reproduce the problem.

cebe commented 4 years ago

Issue is still valid:

Bildschirmfoto von »2020-11-03 13-10-15«

cebe commented 4 years ago

As far as I see this line should only replace "action" when it is at the beginning of the string:

https://github.com/nvlad/yii2support/blob/36e96d605255c4060d77c7ffde31be6cdefaa561/src/com/nvlad/yii2support/common/UrlUtils.java#L53

cebe commented 4 years ago

should be fixed by https://github.com/nvlad/yii2support/pull/257