nvllsvm / freecyngn

A small tool to remove proprietary parts from CyanogenMod 13
Do What The F*ck You Want To Public License
126 stars 10 forks source link

Don't let the script delete CyanogenSetupWizard (fix #29) #31

Closed ghost closed 7 years ago

ghost commented 7 years ago

According to #29, then the script can cause the quick settings and home button to not function (at least on a Nexus 5X and OnePlus 3 on CM13). Removing CyanogenSetupWizard from the script fixes this - but I can't say why.

ghost commented 7 years ago

Can confirm. Not only home button functionality is fully restored and quick settings displayed - notifications, permissions dialogues, usb options via notification, micro SD card config are also back.

This thread documents a very similar situation. According to the thread, it could be a CM bug.

It'd be interesting to know why it's recommended to remove the CM wizard.

ghost commented 7 years ago

@mar-v-in


edit: I see, #13 refers to Google Analytic.

nvllsvm commented 7 years ago

@kehugter A quick look at the CM changed you linked to seems to indicate it might be possible to simply set a flag in the DB.

nvllsvm commented 7 years ago

Closing. This has been resolved without the need for CyanogenSetupWizard.

https://github.com/nvllsvm/freecyngn/blob/1db806bbbf08c86ef32ec53d60e459736ed5f320/20-freecyngn.sh#L29

The procedure for clean installs has changed. See the README.