What kind of changes does this PR introduce? (check at least one)
[ ] Bugfix
[ ] Feature
[ ] Code style update
[X] Refactor
[ ] Build-related changes:
[ ] Other, please describe:
Does this PR introduce a breaking change? (check one)
[ ] Yes
[X] No
If yes, please describe the impact and migration path for existing applications:
If adding a new feature, the PR's description includes:
[ ] A convincing reason for adding this feature
Other information:
Hi,
Thanks a lot for your work on vue-atlas.
I found that solution to avoid that the reset.scss break components from other apps/libs and I wanted to share it. I am not using vue-atlas in "full page" mode. I wanted the reset rules to be applied only in the scope of vue-atlas components. We should perhaps do it a bit differently, I do not know scss very well.
Thanks in advance to review this PR and thanks again for this really good lib!
Cheers,
G
nvms
commented
4 years ago
What kind of changes does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
If adding a new feature, the PR's description includes:
Other information: Hi, Thanks a lot for your work on vue-atlas. I found that solution to avoid that the reset.scss break components from other apps/libs and I wanted to share it. I am not using vue-atlas in "full page" mode. I wanted the reset rules to be applied only in the scope of vue-atlas components. We should perhaps do it a bit differently, I do not know scss very well. Thanks in advance to review this PR and thanks again for this really good lib! Cheers, G