search

nvpro-samples / nvpro_core

shared source code and resources needed for the samples to run
Apache License 2.0
489 stars 114 forks source link

VkMemoryRequirements2 sType must be STRUCTURE_TYPE_MEMORY_REQUIREMENTS_2 #21

Closed rumblehhh closed 4 years ago

rumblehhh commented 4 years ago

VkMemoryRequirements2 structure reqMem does not currently set sType to VK_STRUCTURE_TYPE_MEMORY_REQUIREMENTS_2. https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkMemoryRequirements2-sType-sType

VkMemoryRequirements2 structure reqMem does not currently set pNext to NULL or to a valid instance of VkMemoryDedicatedRequirements. https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkMemoryRequirements2-pNext-pNext

rumblehhh commented 4 years ago

I'm not sure whether this is the best place for mentioning this but this same issue is also present in the vkray-sample-code examples in the zip package downloadable from here: https://developer.nvidia.com/vkray-sample-code. I couldn't find these on github so I'll just point it out here.

rumblehhh commented 4 years ago

Friendly ping. Could anyone take a look at this? Cheers

nvmheyer commented 4 years ago

Thank you! Sorry for not getting back to you earlier - reporting issues is appreciated! The fix for this issue will be live shortly.

rumblehhh commented 4 years ago

Has this been resolved?

mklefrancois commented 4 years ago

Yes, this was done in https://github.com/nvpro-samples/shared_sources/pull/21/commits/f906caec485bd655929d4172e03b636b945ece93