Fix qualification in bird_curve_helper.hpp

[tyler274]

This isnt accepted by GCC or Clang, but is in Visual Studio...did anyone even test this on Linux....?

fixes https://github.com/nvpro-samples/vk_mini_samples/issues/3

[NBickford-NV]

Hi @tyler274 ! Thank you for the merge request - it looks like we've put together a fix for issue #3 upstream already, so it should be included in the next published update to this sample.

For the second issue you mentioned, it looks like the fix is to change [&] to [] in

auto hash  = [&](const nvmath::vec3f& v) { return makeHash(v); };
auto equal = [&](const nvmath::vec3f& l, const nvmath::vec3f& r) { return l == r; };

Testing locally, that should get the samples compiling on Linux.

Thanks again!

[tyler274]

Thank you.

On Tue, May 16, 2023, 23:52 Neil Bickford @.***> wrote:

Hi @tyler274 https://github.com/tyler274 ! Thank you for the merge request - it looks like we've put together a fix for issue #3 https://github.com/nvpro-samples/vk_mini_samples/issues/3 upstream already, so it should be included in the next published update to this sample.

For the second issue you mentioned, it looks like the fix is to change [&] to [] in

auto hash = [&](const nvmath::vec3f& v) { return makeHash(v); };auto equal = [&](const nvmath::vec3f& l, const nvmath::vec3f& r) { return l == r; };

Testing locally, that should get the samples compiling on Linux.

Thanks again!

— Reply to this email directly, view it on GitHub https://github.com/nvpro-samples/vk_mini_samples/pull/4#issuecomment-1550401962, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7UPA7JFHQUEUW6ZQJ5S2DXGPZK7ANCNFSM6AAAAAAYDQ37AA . You are receiving this because you were mentioned.Message ID: @.***>

[tyler274]

Spoke too soon, there's another compile time error in clang 15 with format strings

[mklefrancois]

Thanks for the patch, this was fixed in b38052d