nvpro-samples / vk_raytrace

Ray tracing glTF scene with Vulkan
Apache License 2.0
551 stars 34 forks source link

fix bugs #22

Closed IwakuraRein closed 1 year ago

IwakuraRein commented 1 year ago

call m_pRender[m_rndMethod]->destroy() before m_pRender[m_rndMethod]->create(). Otherwise, the previous pipeline and pipeline layout won't be destroyed when a scene is loaded.

add if (m_busy) return; to SampleExample::onKeyboard(). Otherwise, when user is pressing the keyboard while loading the scene, some unpredictable multithread bugs may happen.

Signed-off-by: Alex alexfu@seas.upenn.edu

IwakuraRein commented 1 year ago

Sorry for making this sign-off issue again.

And seems SampleExample::onMouseMotion() has the same problem as SampleExample::onKeyboard(). Adding if (m_busy) return; solved it.

mklefrancois commented 1 year ago

Thanks @IwakuraRein for fix proposals. Can you please check the DCO for the signoff. Thanks